igraph dfs may signal unreachable nodes with 0 #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jefferis
commented
Jan 16, 2024
jefferis
commented
- this still seems to be up in the air but at least some preparatory branches for igraph 2.0 use a 0 rather than NaN to signal unreachable nodes
- see Compatibility with igraph 2.0.0 #517
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #518 +/- ##
=======================================
Coverage 76.88% 76.89%
=======================================
Files 48 48
Lines 5935 5937 +2
=======================================
+ Hits 4563 4565 +2
Misses 1372 1372 ☔ View full report in Codecov by Sentry. |
krlmlr
reviewed
Jan 20, 2024
| verticestoprune=setdiff(seq_len(nvertices), verticestoprune) | ||
| } else { | ||
| verticestoprune=setdiff(verticestoprune, 0) |
There was a problem hiding this comment.
Thanks a lot for the review @krlmlr, but this is still necessary because nat sets igraph::igraph_options(return.vs.es = FALSE) (because in the past I have found this makes a significant difference to some operations) and as noted here your recent changes to the handling of unreachable nodes are only valid when igraph::igraph_options(return.vs.es = TRUE). To me that's a bug, but I'm not sure if you plan to fix. Thanks! Greg.
jefferis
force-pushed
the
fix/igraph200
branch
from
3c44185
to
c1aacf8
Compare
* there are many functions deprecated in igraph v2.0.0 * unfortunately, I don't know what is the minimum igraph version for the new function names currently we only require igraph (>= 0.7.1) get.vertex.attribute->vertex_attr add.edges->add_edges decompose.graph->decompose graph.bfs->bfs graph.dfs->dfs is.connected->is_connected is.directed->is_directed get.vertex.attribute->vertex_attr shortest.paths->distances get.shortest.paths->shortest_paths induced.subgraph -> induced_subgraph no.clusters -> count_components clusters -> components minimum.spanning.tree -> mst delete.vertices -> delete_vertices set.vertex.attribute -> set_vertex_attr get.edgelist -> as_edgelist delete.edges -> delete_edges
* this still seems to be up in the air but at least some preparatory branches for igraph 2.0 use a 0 rather than NaN to signal unreachable nodes * see #517
* used to be an int, now numeric with igraph 2.0
* I don't think this is so restrictive anymore and I think but have not fully checked that some of the functions deprecated in igraph 2.0 have been replaced by functions defined in igraph 1.0 but not earlier.
* there are still places in the code like
In file included from /home/runner/src/cmtk/core/libs/IO/cmtkImageFileDICOM.cxx:33:
/home/runner/src/cmtk/core/libs/IO/cmtkImageFileDICOM.h:45:10: fatal error: dcmtk/dcmdata/dctk.h: No such file or directory
45 | #include <dcmtk/dcmdata/dctk.h>
| ^~~~~~~~~~~~~~~~~~~~~~
where headers are expected
* otherwise it's not available
jefferis
force-pushed
the
fix/igraph200
branch
from
6cc5764
to
ed74ce2
Compare
* there's a failure on github actions I can't yet figure out ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.